[FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

[Jun Li]

On Sat, May 25, 2019 at 2:46 AM Nicolas George <george at nsup.org> wrote:

> Jun Li (12019-05-24):
> > Add exif orientation support and expose an option.
> > ---
> >  libavfilter/vf_transpose.c | 258 +++++++++++++++++++++++++++++--------
> >  1 file changed, 207 insertions(+), 51 deletions(-)
>
> If I read the code correctly, when orientation=1 (unchanged), this code
> will copy the frame instead of just passing it unchanged. Did I miss
> something?
>

    return 0;
@@ -334,7 +485,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame
*in)
     ThreadData td;
     AVFrame *out;

-    if (s->passthrough)
+    if (s->passthrough || s->orientation == 1)

I believe this line skip the frame copy ?

         return ff_filter_frame(outlink, in);


>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".