[FFmpeg-devel] [PATCH]lavc/sbc: Remove bool usage

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Apr 2 10:59:20 EEST 2020

Am Mi., 1. Apr. 2020 um 23:23 Uhr schrieb Thierry Foucu <tfoucu at gmail.com>:
> On Wed, Apr 1, 2020 at 12:31 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > Hi!
> >
> > It seems to me that this was forgotten when the codec was originally
> > ported.
> >
> why removing "stdbool.h"?

We never liked it (and I am sure there are examples of rejected patches),
in this particular case, looking at the code, it was just an oversight when
cleaning the code of bool.

> it was defined in 2001?

> so, most compiler should support it..

I hope you find the most important word in your sentence;-)

> Should we not check for the compiler support of it and if not, then either
> reject the compiler or defines the type ourself?

It seems significantly easier to avoid it.

Carl Eugen

More information about the ffmpeg-devel mailing list