[FFmpeg-devel] [PATCH] avutil/log: update text requesting samples

[Marton Balint]

On Sat, 4 Apr 2020, Carl Eugen Hoyos wrote:

> Am Sa., 4. Apr. 2020 um 19:26 Uhr schrieb Marton Balint <cus at passwd.hu>:
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  libavutil/log.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/libavutil/log.c b/libavutil/log.c
>> index 8d4945249e..a0b2348bd5 100644
>> --- a/libavutil/log.c
>> +++ b/libavutil/log.c
>> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg,
>>             "occurs, it means that your file has a feature which has not "
>>             "been implemented.\n");
>>      if (sample)
>> -        av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample "
>> -               "of this file to ftp://upload.ffmpeg.org/incoming/ "
>> -               "and contact the ffmpeg-devel mailing list. (ffmpeg-devel at ffmpeg.org)\n");
>> +        av_log(avc, AV_LOG_WARNING, "If you want to help, open an enhancement "
>> +            "ticket on https://trac.ffmpeg.org/ and upload a sample of this "
>> +            "file to https://streams.videolan.org/upload/\n");
>
> The change to the upload link is good, I would prefer if we
> do not ask for opening a ticket in every such case.

Why? Isn't the issue tracker more suitable for this then simple email? 
Also, when you upload the file you reference the ticket, so the file will 
be put into the proper directory (right?) and you will know why the file 
is interesting by checking the ticket. Otherwise you get a file without a 
ticket number or proper description and good luck figuring out later why 
that got uploaded in the first place.

>
> I believe I have dealt with every such (rare) mail in the past.

If it is so rare, then one more reason why it should not matter. ;)

Thanks,
Marton