[FFmpeg-devel] [PATCH 2/2] lavfi/framesync: use av_gcd_q().

Nicolas George george at nsup.org
Thu Apr 16 23:30:36 EEST 2020

Andreas Rheinhardt (12020-04-16):
> lcm is now unused, so should be removed with this commit.
> (I'm not commenting on the actual merits of the patch.)

Indeed. I updated the patch, it now contains an extra hunk:

@@ -117,7 +117,6 @@ static void framesync_sync_level_update(FFFrameSync *fs)
 int ff_framesync_configure(FFFrameSync *fs)
     unsigned i;
-    int64_t gcd, lcm;
     if (!fs->opt_repeatlast || fs->opt_eof_action == EOF_ACTION_PASS) {
         fs->opt_repeatlast = 0;

And I think I can dispense with re-sending it.

> PS: Thanks to Andriy for adding the functionality to patchwork to check
> whether a patch introduces new compiler warnings. This has been found
> this way.

It is useful indeed. But I should have spotted it. Thanks.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200416/d7c5fae4/attachment.sig>

More information about the ffmpeg-devel mailing list