[FFmpeg-devel] [PATCH 6/8] avcodec/dump_extradata_bsf: Remove unnecessary header

Anton Khirnov anton at khirnov.net
Tue Apr 21 13:02:43 EEST 2020

Quoting Andreas Rheinhardt (2020-04-21 04:31:51)
> Since 33d18982fa03feb061c8f744a4f0a9175c1f63ab (the commit that
> introduced the new bsf API) allocating an enlarged buffer in case
> extradata needs to be added to a packet is done via av_new_packet(),
> so that libavutil/mem.h is no longer needed.
> Furthermore, remove libavutil/log.h. This function uses something
> provided by it (an AVClass), yet it does so only for AVOptions, not
> for logging purposes (there is no av_log() here), so only including
> libavutil/opt.h seems appropriate.

IMO each file should include the headers for all the definitions it uses
directly. I.e. if a file uses AVClass, it should include log.h.

But I suppose it does not matter much in pracice (in this case
especially), so feel free to ignore me.

Anton Khirnov

More information about the ffmpeg-devel mailing list