[FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

[Nicolas George]

Limin Wang (12020-04-29):
> yes, avio_write can process zero len with NULL pointer, but here it'll use buf+written_len, so
> it's invalid access I think. So what's the broken? Maybe I haven't catch your point.

What's broken is that the code is supposed to do something, and with
your change it does not do it.

These changes are therefore not acceptable.

The invalid access need to be fixed, but they need to be fixed properly:
since they correspond to a memory allocation failure, there should be
some kind of AVERROR(ENOMEM) in there.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200429/1c5c77ca/attachment.sig>