[FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

Jan Ekström jeebjp at gmail.com
Thu Aug 6 13:15:24 EEST 2020

On Thu, Aug 6, 2020 at 3:16 AM Takio Yamaoka <y.takio at gmail.com> wrote:
> 2020年8月6日(木) 7:24 Jan Ekström <jeebjp at gmail.com>:
> >
> > Sorry, decided to take a look at the logic but didn't have the time to
> > actually test it locally.
> Thank you for replying. It sounds good for me.
> > I have now tested it locally and it works as expected with the
> > following test cases:
> > <unset> and chromaoffset 0 (still kept at default, which is zero with x264)
> > chromaoffset -3
> > chromaoffset 5
> >
> > Looking at the history, it was originally implemented correctly in
> > 5764d38173661c29d954711dd5abfddf709e9ba4 but then broken in
> > b340bd8a58c32453172404a8e4240e3317e341da .
> Yes, Thanks. I did the same thing.
> So, I should pasted test results and history of this. I'm sorry for
> bothering you.
> > If you are OK with the following rewording of the commit message, I
> > can push it tomorrow after work:
> Of course! Thank you for correcting me.
> I have learned a lot from this commit log.

Cheers. Applied as cc6c56f5d900f86167f6592215e613a69341858a .

Thanks for noticing that this was broken and sending out a patch.

> > P.S. Top-posting is frowned upon on this mailing list, so please reply
> > in-line or underneath in the future, if possible.
> Oh, I'm sorry that my email must be difficult to read...
> I greatly appreciate your advice. I'm going to follow these rules.
> #Is it fine in the above replying?

I do not consider it too difficult to read as it's the more common way
people utilize e-mail these days, but I just decided to note the
practice on this mailing list before someone else did it in less nice
words ;)


More information about the ffmpeg-devel mailing list