[FFmpeg-devel] [PATCH 2/2] avcodec/dynamic_hdr10_plus: don't take a GetBitContext as input argument

Jan Ekström jeebjp at gmail.com
Mon Dec 7 01:34:20 EET 2020

On Mon, Dec 7, 2020 at 1:23 AM Jan Ekström <jeebjp at gmail.com> wrote:
> On Sun, Dec 6, 2020 at 5:44 PM James Almer <jamrial at gmail.com> wrote:
> >
> > Create a local one instead from a byte buffer input argument.
> >
> > Signed-off-by: James Almer <jamrial at gmail.com>
> The actual change mentioned in the commit message is LGTM, and the
> updated sanity checks seem good (since now the alternatives at that
> point are either 3+3 (2094-40) or 3+4 (closed captions)), but they are
> pretty separate from the actual change of this commit. So in that
> sense it might make sense to just separate them into their own fixup
> commit when pushing. Or at least mention the sanity check fixups in
> the commit message instead of them being a silent good change.

For the record, I only now grasped after it being mentioned that what
I took for just sanity check fixups are actually needed for the gdc
changes since otherwise the size variable's value is out-of-sync.

So yea, overall LGTM as long as that part of the change set is
mentioned, since otherwise it just looked like nice (but unrelated)
sanity check fixups.


More information about the ffmpeg-devel mailing list