[FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

Paul B Mahol onemda at gmail.com
Sat Feb 1 17:17:10 EET 2020

On 2/1/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Tue, Jan 14, 2020 at 04:04:29PM +0100, Paul B Mahol wrote:
>> This better belong to generic code.
> This specific check (which checks for INT_MAX) is specific to our
> bink audio code which does a +1
> so it would not fit in generic code
> We could arbitrarily decide on a maximum sample rate hardcode that
> and check for that in generic code.
> I can implement that if people prefer. It would not avoid all
> sample rate checks in codecs though ...

sample rate can not be > INT_MAX

> Thanks
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> In a rich man's house there is no place to spit but his face.
> -- Diogenes of Sinope

More information about the ffmpeg-devel mailing list