[FFmpeg-devel] Project orientation
Michael Niedermayer
michael at niedermayer.cc
Mon Jul 6 02:18:13 EEST 2020
On Sun, Jul 05, 2020 at 09:56:02PM +0000, Soft Works wrote:
> ... A significant part of code reviews are code-style violations. This is
> really not something where humans should need to spend time for when
> reviewing a patch.
you are correct but that is also the easy part of reviews.
Its not what makes reviews time consuming.
Rather while reviewing for technical stuff one notices maybe a formating
issue
> Neither should it be required that Michael responds manually each time
> by stating "breaks FATE".
We already have fully automatic build and fate tests for submitted patches
its done by patchwork which should send a private mail to the submitter of
a patch affected.
Still not every environment is the same, and it passing on the patchwork
box doesnt mean it builds on my mingw or mips environments for example.
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
"I am not trying to be anyone's saviour, I'm trying to think about the
future and not be sad" - Elon Musk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200706/f35cfc31/attachment.sig>
More information about the ffmpeg-devel
mailing list