[FFmpeg-devel] [PATCH] avfilter: add afwtdn filter
Reino Wijnsma
rwijnsma at xs4all.nl
Mon Jun 1 00:26:44 EEST 2020
On 2020-05-31T22:37:20+0200, Paul B Mahol <onemda at gmail.com> wrote:
> On 5/31/20, Nicolas George <george at nsup.org> wrote:
>> Paul B Mahol (12020-05-31):
>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>> ---
>>> libavfilter/Makefile | 1 +
>>> libavfilter/af_afwtdn.c | 619 +++++++++++++++++++++++++++++++++++++++
>>> libavfilter/allfilters.c | 1 +
>>> 3 files changed, 621 insertions(+)
>>> create mode 100644 libavfilter/af_afwtdn.c
>> No doc, name completely impossible to understand. Unacceptable.
> Go away!
Can you please act as a grown-up for once?!
Nicolas is right. How would anyone be able to understand what your patch does. No name, no discription, no documentation. Nothing!
I would immediately reject this patch if this would be my project.
Whatever issue you have with Nicolas, I suggest you two have a serious conversation about this, preferably face-to-face if possible, and talk this out! I've been around here long enough to see that it's polluting this mailinglist.
-- Reino
More information about the ffmpeg-devel
mailing list