[FFmpeg-devel] [PATCH 1/2 v4] avcodec/encode: restructure the core encoding code

[James Almer]

On 5/26/2020 9:08 AM, Michael Niedermayer wrote:
> On Mon, May 25, 2020 at 01:59:16PM -0300, James Almer wrote:
>> This commit follows the same logic as 061a0c14bb, but for the encode API: The
>> new public encoding API will no longer be a wrapper around the old deprecated
>> one, and the internal API used by the encoders now consists of a single
>> receive_packet() callback that pulls frames as required.
>>
>> amf encoders adapted by James Almer
>> librav1e encoder adapted by James Almer
>> nvidia encoders adapted by James Almer
>> MediaFoundation encoders adapted by James Almer
>> vaapi encoders adapted by Linjie Fu
>> v4l2_m2m encoders adapted by Andriy Gelman
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Rebased the old set didn't apply anymore, and now including all the changes to
>> the affected encoders, so it's ready to commit, but preferably after 4.3 is
>> released.
> 
> this breaks FFV1 2 pass encoding
> 
> random testcase:
> ./ffmpeg -y  -i mm-short.mpg -an -vcodec ffv1 -strict -2 -slices 4 -t 1 -coder 1 -level 2 -context 1 -pass 1 ffv1.avi
> the problem is with the 2pass log file, it is empty

This is already fixed in the version i'll push (v5), but could you add a
fate test for it nonetheless? 2pass seems like an important feature that
should be tested to prevent breakage like this going unnoticed.

Also, it would be nice if libx264 didn't have a custom implementation
hacked into ffmpeg.c itself as well, seeing it can't be tested for being
an external library.

> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>