[FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

[Nicolas George]

lance.lmwang at gmail.com (12020-06-22):
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavutil/opt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 2c3f998..552985e 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -2120,6 +2120,9 @@ int av_opt_serialize(void *obj, int opt_flags, int flags, char **buffer,
>              av_freep(&buf);
>          }
>      }
> -    av_bprint_finalize(&bprint, buffer);
> +    ret = av_bprint_finalize(&bprint, buffer);
> +    if (ret < 0)
> +        return ret;
> +
>      return 0;
>  }

The extra empty line seems unnecessary. LGTM otherwise.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200624/e06005e8/attachment.sig>