[FFmpeg-devel] [PATCH, v2 1/4] tests/checkasm: add overflow test for hevc_add_res

Fu, Linjie linjie.fu at intel.com
Thu Mar 5 09:42:14 EET 2020


> -----Original Message-----
> From: Fu, Linjie <linjie.fu at intel.com>
> Sent: Thursday, March 5, 2020 15:17
> To: ffmpeg-devel at ffmpeg.org
> Cc: Fu, Linjie <linjie.fu at intel.com>; Xu, Guangxin <guangxin.xu at intel.com>
> Subject: [PATCH,v2 1/4] tests/checkasm: add overflow test for hevc_add_res
> 
> Add overflow test for hevc_add_res when int16_t coeff = -32768,
> and doubled the test cases.
> 
> The result of C is good, while ASM is not.
> 
> To verify:
>     make fate-checkasm-hevc_add_res
>     ffmpeg/tests/checkasm/checkasm --test=hevc_add_res
> 
> ./checkasm --test=hevc_add_res
> checkasm: using random seed 679391863
> MMXEXT:
>     hevc_add_res_4x4_8_mmxext (hevc_add_res.c:69)
>   - hevc_add_res.add_residual [FAILED]
> SSE2:
>     hevc_add_res_8x8_8_sse2 (hevc_add_res.c:69)
>     hevc_add_res_16x16_8_sse2 (hevc_add_res.c:69)
>     hevc_add_res_32x32_8_sse2 (hevc_add_res.c:69)
>   - hevc_add_res.add_residual [FAILED]
> AVX:
>     hevc_add_res_8x8_8_avx (hevc_add_res.c:69)
>     hevc_add_res_16x16_8_avx (hevc_add_res.c:69)
>     hevc_add_res_32x32_8_avx (hevc_add_res.c:69)
>   - hevc_add_res.add_residual [FAILED]
> AVX2:
>     hevc_add_res_32x32_8_avx2 (hevc_add_res.c:69)
>   - hevc_add_res.add_residual [FAILED]
> checkasm: 8 of 14 tests have failed
> 
> Signed-off-by: Xu Guangxin <guangxin.xu at intel.com>
> Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> ---
> [v2]: test 2x cases to make sure the random residuals
> could be testd.
> 

This modification in fate should be put after the fix patch(2~4),
Otherwise it would break fate test in CI.

I'll resend the set, sorry for the noise.

- Linjie


More information about the ffmpeg-devel mailing list