[FFmpeg-devel] [PATCH 1/2] avcodec/siren: Fix integer overflow in get_dw()

Michael Niedermayer michael at niedermayer.cc
Wed Mar 18 21:20:43 EET 2020


Fixes: signed integer overflow: 685813396 + 1803454769 cannot be represented in type 'int'
Fixes: 21073/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SIREN_fuzzer-5744900508483584

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/siren.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/siren.c b/libavcodec/siren.c
index 76dfe62843..1c17d4505d 100644
--- a/libavcodec/siren.c
+++ b/libavcodec/siren.c
@@ -363,7 +363,7 @@ typedef struct SirenContext {
     int sample_rate_bits;
     int region_size;
 
-    int dw1, dw2, dw3, dw4;
+    unsigned dw1, dw2, dw3, dw4;
 
     int absolute_region_power_index[32];
     float decoder_standard_deviation[32];
-- 
2.17.1



More information about the ffmpeg-devel mailing list