[FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

[Michael Niedermayer]

On Thu, May 07, 2020 at 12:25:34PM +0100, Josh de Kock wrote:
> The NEON hscale function only supports X8 filter sizes and should only
> be selected when these are being used.
> 
> Signed-off-by: Josh de Kock <josh at itanimul.li>
> ---
>  libswscale/aarch64/swscale.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libswscale/aarch64/swscale.c b/libswscale/aarch64/swscale.c
> index 54a3beabe8..eecbea88ca 100644
> --- a/libswscale/aarch64/swscale.c
> +++ b/libswscale/aarch64/swscale.c
> @@ -34,7 +34,10 @@ av_cold void ff_sws_init_swscale_aarch64(SwsContext *c)
>      int cpu_flags = av_get_cpu_flags();
>  
>      if (have_neon(cpu_flags)) {
> -        if (c->srcBpc == 8 && c->dstBpc <= 14) {
> +        if (c->srcBpc == 8 && c->dstBpc <= 14 &&
> +            (c->hLumFilterSize % 8) == 0 &&
> +            (c->hChrFilterSize % 8) == 0)
> +        {
>              c->hyScale = c->hcScale = ff_hscale_8_to_15_neon;
>          }

isnt filterAlign set to 8 when neon is available ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200508/07ed0807/attachment.sig>