[FFmpeg-devel] [PATCH 2/4] avcodec.h: split AVCodecParameters API into its own header

[Anton Khirnov]

Quoting James Almer (2020-04-11 17:44:51)
> On 4/10/2020 12:41 PM, Anton Khirnov wrote:
> > ---
> > Not sure what to do with AVFieldOrder. It gets moved to codec_par.h
> > since it is used in AVCodecParameters, but it isn't precisely the right
> > place for it, though it's not horribly wrong either.
> 
> How about moving it to lavu's pixfmt.h, alongside other format definitions?

It's a property of a coded bitstream, so pixfmt seems like the wrong
place for it.

> 
> > 
> > Least bad solution I've come up with is making a separate header for
> > "misc small types used in lavc" and move there:
> > - AVFieldOrder
> > - AVAudioServiceType
> > - AVPanScan
> > - AVCPBProperties
> > - AVProducerReferenceTime
> > - AVProfile
> > - AVPictureStructure
> > 
> > but
> > - it's a "misc" header and misc headers are evil
> > - I can't come up with a good name for it
> > 
> > Suggestions?
> 
> AVCPBProperties and AVProducerReferenceTime are both packet or codec
> coded side data, so maybe they could be moved to packet.h, or to codec_par.h
> AVProfile is used by AVCodec only, AVAudioServiceType by AVCodecContext
> only, and AVPictureStructure by AVCodecParserContext only, so IMO they
> should be in the same header as their users.

They are used by those structs *now*. That can change in the future.

-- 
Anton Khirnov