[FFmpeg-devel] [PATCH 8/9] avfilter/vf_subtitles: Return early upon avformat_open_input() failure

Nicolas George george at nsup.org
Fri Sep 11 12:19:07 EEST 2020

Andreas Rheinhardt (12020-09-10):
> There is nothing to free at this point.
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/vf_subtitles.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does it help anything? If something gets allocated earlier, we will need
to add it back. When there is a comprehensive cleanup label, using it
always seems more robust than guessing if something needs freeing or


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200911/c0aafe1d/attachment.sig>

More information about the ffmpeg-devel mailing list