[FFmpeg-devel] [PATCH v2] fftools/cmdutils: don't print build configuration by default

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Lynne
> Sent: Friday, 6 August 2021 23:30
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/cmdutils: don't print build
> configuration by default
> 
> 6 Aug 2021, 23:17 by jamrial at gmail.com:
> 
> > Suggested-by: ffmpeg at fb.com
> > Signed-off-by: James Almer <jamrial at gmail.com>
> > ---
> >  fftools/cmdutils.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index
> > 912e881174..e6ae749167 100644
> > --- a/fftools/cmdutils.c
> > +++ b/fftools/cmdutils.c
> > @@ -1152,6 +1152,8 @@ static void print_all_libs_info(int flags, int
> > level)  static void print_program_info(int flags, int level)  {  const
> > char *indent = flags & INDENT? "  " : "";
> > +    // Show config only if level is verbose or higher
> > +    int config_level = level <= AV_LOG_INFO ? AV_LOG_VERBOSE : level;
> >
> >  av_log(NULL, level, "%s version " FFMPEG_VERSION, program_name);  if
> > (flags & SHOW_COPYRIGHT) @@ -1160,7 +1162,7 @@ static void
> > print_program_info(int flags, int level)  av_log(NULL, level, "\n");
> > av_log(NULL, level, "%sbuilt with %s\n", indent, CC_IDENT);
> >
> > -    av_log(NULL, level, "%sconfiguration: " FFMPEG_CONFIGURATION "\n",
> indent);
> > +    av_log(NULL, config_level, "%sconfiguration: "
> > + FFMPEG_CONFIGURATION "\n", indent);
> >  }
> >
> >  static void print_buildconf(int flags, int level)
> > --
> > 2.32.0
> >
> 
> That's even worse. Verbose is too verbose to be useful, especially
> when parsing H264 in MP4.

You are right. There are two or three annoying outputs with loglevel
VERBOSE. I had changed those to TRACE and VERBOSE is now very
useful and actually my preferred level when testing things.

softworkz