[FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

Derek Buitenhuis derek.buitenhuis at gmail.com
Sun Aug 8 15:00:30 EEST 2021


On 8/8/2021 9:28 AM, Michael Niedermayer wrote:
> +$req_slot =~ s/[^-._A-Za-z0-9 ]*//g;

I don't think it is wise to allow periods here, considering
we use string ops to append it to a dir name just below.

.. and we probably should not be using string ops to construct
directory names.

> +$req_time =~ s/[^0-9]*//g;

We should validate this is an actual time, probably.

- Derek


More information about the ffmpeg-devel mailing list