[FFmpeg-devel] [PATCH] hwcontext_vulkan: make 2 public functions always available

Hendrik Leppkes h.leppkes at gmail.com
Fri Dec 3 15:20:56 EET 2021


On Thu, Dec 2, 2021 at 7:13 PM Andreas Rheinhardt
<andreas.rheinhardt at outlook.com> wrote:
> 2. And even if not: Actually compiling the whole implementation is
> unnecessary; in such cases we typically #if everything away (e.g. in
> your case: it will always return NULL).
> 3. The hwcontext_vulkan.h header requires vulkan system headers; you
> can't compile this without it.
>

I meant to put this into the other mail, but I agree with these two
points. Obviously we can't expect that vulkan headers are always
available, so these "always available" functions should just be empty
stubs that return NULL when vulkan is not enabled at compile time.

- Hendrik


More information about the ffmpeg-devel mailing list