[FFmpeg-devel] [PATCH] avcodec/libkvazaar: Set default ratecontrol algorithm for libkvazaar

[Linjie Fu]

On Thu, Dec 10, 2020 at 3:28 PM Linjie Fu <linjie.justin.fu at gmail.com> wrote:
>
> On Thu, Dec 10, 2020 at 2:09 PM Joose Sainio <joose.sainio at tuni.fi> wrote:
> >
> > The standalone version of Kvazaar sets a default ratecontrol algorithm when
> > bitrate is set. Mirror this behaviour.
> >
> > Signed-off-by: Joose Sainio <joose.sainio at tuni.fi>
> > ---
> >   libavcodec/libkvazaar.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
> > index 9032547678..68ce7ad58c 100644
> > --- a/libavcodec/libkvazaar.c
> > +++ b/libavcodec/libkvazaar.c
> > @@ -95,6 +95,9 @@ static av_cold int libkvazaar_init(AVCodecContext *avctx)
> >       cfg->target_bitrate = avctx->bit_rate;
> >       cfg->vui.sar_width  = avctx->sample_aspect_ratio.num;
> >       cfg->vui.sar_height = avctx->sample_aspect_ratio.den;
> > +    if(avctx->bit_rate){
> > +        cfg->rc_algorithm = KVZ_LAMBDA;
> > +    }
> >
> >       if (ctx->kvz_params) {
> >           AVDictionary *dict = NULL;
> >
> >
> Looks reasonable,  fixed the encoding failure if explicitly setting
> bitrate through "-b:v 3M".
> And the result matches the behaviour of -kvazaar-params "bitrate=3000000".
>
Prefer to apply if no objection.

- linjie