[FFmpeg-devel] [PATCH 16/16] avfilter/vsrc_testsrc: Deduplicate options

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Jan 4 21:22:17 EET 2021


Nicolas George:
> Hi.
> 
> Andreas Rheinhardt (12021-01-04):
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>  libavfilter/vsrc_testsrc.c | 15 +++++----------
>>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> IIRC, options tables cannot be de-duplicated, because of some
> enumerating code. Or am I confusing with something else?
> 

What enumerating code? It is actually commonplace that options are
shared (you can find examples in libavfilter by using 'git grep -e
define --and -e options'); pointing into other options and thereby
reusing only a part of other options is not common, but I don't really
see why it shouldn't work.

- Andreas


More information about the ffmpeg-devel mailing list