[FFmpeg-devel] [PATCH 12/54] avformat/concatdec: Simplify cleanup after read_header failure

Nicolas George george at nsup.org
Wed Jun 16 12:15:12 EEST 2021


Andreas Rheinhardt (12021-06-16):
> by setting the FF_FMT_INIT_CLEANUP flag.
> 
> (Btw: concat_read_close() is not idempotent (it frees cat->files, but
> doesn't reset cat->nb_files), so this demuxer was incompatible with
> simply calling read_close generically upon read_header failure.)
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavformat/concatdec.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Looks ok. I am perfectly fine with clearing nb_files along with files to
make concat_read_close idempotent.

Thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210616/3d628b1f/attachment.sig>


More information about the ffmpeg-devel mailing list