[FFmpeg-devel] [PATCH v2] avformat: add a concat protocol that takes a line break delimited list of resources

Nicolas George george at nsup.org
Sun Jun 27 22:40:02 EEST 2021


James Almer (12021-06-27):
> Only line breaks need to be escaped. I said as much and even suggested to
> make it more explicit in the documentation.
> Every other character will be read and added verbatim into a string used as
> uri for a given resource that ffurl_open_whitelist() will then handle.
> 
> Create a text file with the following four entries
> 
> foo\
> bar.h264
> foo'bar.h264
> foo\bar.h264
> foobar.h264
> 
> Where only the line break is escaped to ensure it's not interpreted as a
> resource name delimiter, and they will all be read and open if they exist.

I do not need you to explain this to me.

> There's no need for any escaping other than the delimiter character, so
> wouldn't it be misleading linking to a document that will make you write
> your entries in the file in a way that will not work?

The code and documentation must be compatible, of course.

> Said documentation will tell you that if you want to load foo'bar.h264 you
> will need to write it as foo\'bar.h264, but that's not true here and will

That should be true, see below.

> Wont your request to use escaping functions result in the need for the
> entries in the text file to start pointlessly escaping characters like
> quotes, backslashes and others for no reason, as if this were bash?

My request results in using the same syntax we have developed and tuned
for the rest of the project.

Having several subtly different rules for escaping in a single project
is an abominable idea.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210627/9b099ab3/attachment.sig>


More information about the ffmpeg-devel mailing list