[FFmpeg-devel] [PATCH 5/5] lavfi/dnn_backend_native_layer_mathunary.h: Documentation

[Shubhanshu Saxena]

On Sun, May 9, 2021 at 1:55 PM Anton Khirnov <anton at khirnov.net> wrote:

> Quoting Shubhanshu Saxena (2021-05-08 14:13:07)
> > Add documentation for Unary Math Layer
> >
> > Signed-off-by: Shubhanshu Saxena <shubhanshu.e01 at gmail.com>
> > ---
> >  .../dnn/dnn_backend_native_layer_mathunary.h  | 64 +++++++++++++------
> >  1 file changed, 46 insertions(+), 18 deletions(-)
> >
> > diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> b/libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> > index 151a73200a..869fdc16fd 100644
> > --- a/libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> > +++ b/libavfilter/dnn/dnn_backend_native_layer_mathunary.h
> > @@ -30,31 +30,59 @@
> >  #include "dnn_backend_native.h"
> >
> >  typedef enum {
> > -    DMUO_ABS = 0,
> > -    DMUO_SIN = 1,
> > -    DMUO_COS = 2,
> > -    DMUO_TAN = 3,
> > -    DMUO_ASIN = 4,
> > -    DMUO_ACOS = 5,
> > -    DMUO_ATAN = 6,
> > -    DMUO_SINH = 7,
> > -    DMUO_COSH = 8,
> > -    DMUO_TANH = 9,
> > -    DMUO_ASINH = 10,
> > -    DMUO_ACOSH = 11,
> > -    DMUO_ATANH = 12,
> > -    DMUO_CEIL = 13,
> > -    DMUO_FLOOR = 14,
> > -    DMUO_ROUND = 15,
> > -    DMUO_EXP = 16,
> > -    DMUO_COUNT
> > +    DMUO_ABS = 0,    // Absolute Value
> > +    DMUO_SIN = 1,    // Sine
> > +    DMUO_COS = 2,    // Cosine
> > +    DMUO_TAN = 3,    // Tangent
> > +    DMUO_ASIN = 4,   // Inverse Sine
> > +    DMUO_ACOS = 5,   // Inverse Cosine
> > +    DMUO_ATAN = 6,   // Inverse Tangent
> > +    DMUO_SINH = 7,   // Hyperbolic Sine
> > +    DMUO_COSH = 8,   // Hyperbolic Cosine
> > +    DMUO_TANH = 9,   // Hyperbolic Tangent
> > +    DMUO_ASINH = 10, // Inverse Hyperbolic Sine
> > +    DMUO_ACOSH = 11, // Inverse Hyperbolic Cosine
> > +    DMUO_ATANH = 12, // Inverse Hyperbolic Tangent
> > +    DMUO_CEIL = 13,  // Ceiling
> > +    DMUO_FLOOR = 14, // Floor
> > +    DMUO_ROUND = 15, // Round off to Nearest Integer
> > +    DMUO_EXP = 16,   // Exponential
> > +    DMUO_COUNT       // Total Number of Operators
>
> Every single one of those is obvious from the enum name itself, the
> comments just add more visual clutter.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>

Sure, I'll remove them. Thanks.