[FFmpeg-devel] [PATCH 1/3] avfilter/avfiltergraph: Remove NULL checks after dereferences

Michael Niedermayer michael at niedermayer.cc
Wed May 19 00:39:08 EEST 2021


Fixes: CID1398579 Dereference before null check

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavfilter/avfiltergraph.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index ed54d3dc11..5389d82d9f 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
@@ -1360,8 +1360,8 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph)
         if (r != AVERROR_EOF)
             break;
         av_log(oldest->dst, AV_LOG_DEBUG, "EOF on sink link %s:%s.\n",
-               oldest->dst ? oldest->dst->name : "unknown",
-               oldest->dstpad ? oldest->dstpad->name : "unknown");
+               oldest->dst->name,
+               oldest->dstpad->name);
         /* EOF: remove the link from the heap */
         if (oldest->age_index < --graph->sink_links_count)
             heap_bubble_down(graph, graph->sink_links[graph->sink_links_count],
-- 
2.17.1



More information about the ffmpeg-devel mailing list