[FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

Nicolas George george at nsup.org
Sat Oct 9 13:06:40 EEST 2021

Andreas Rheinhardt (12021-10-09):
> Quite a lot of these process_command callbacks are actually quite
> boilerplate; lots of them are just ff_filter_process_command(). I
> actually intended to factor out this common part in a subsequent patch:
> https://github.com/mkver/FFmpeg/commits/process_command This would make
> the flag non-redundant, because then quite a lot of filters supporting
> commands would no longer have a process_command callback at all.

If they are just ff_filter_process_command(), then the best course of
action is to just make them ff_filter_process_command(), directly in the
callback. No flag required.

> And adding a getter for something that is essentially a flag is IMO very
> inelegant.

Maintaining an information manually when it can be derived from a more
authoritative source is worse.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211009/c0110e7d/attachment.sig>

More information about the ffmpeg-devel mailing list