[FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter

Nicolas George george at nsup.org
Sun Jul 3 16:27:58 EEST 2022

Tong Wu (12022-07-03):
> When two formats lists cannot be merged, a scale filter is
> auto-inserted. However, when it comes to hardware map, we have to
> manually add a hwmap filter to do the conversion. This patch introduces
> an auto hwmap filter to do the hwmap conversion automatically and
> modifies the negotiation structures, making it extensible for more auto
> filters.
> Signed-off-by: Tong Wu <tong1.wu at intel.com>
> ---
>  libavfilter/avfiltergraph.c | 183 ++++++++++++++++++++++++------------
>  libavfilter/formats.c       |  26 ++++-
>  libavfilter/formats.h       |   9 +-
>  3 files changed, 150 insertions(+), 68 deletions(-)

Hi, thanks for the patch. It looks a bit hard to review due to the
amount of moved code.

Can you split the patch into two: (1) moving and reindenting the code
into an auxiliary function without functional changes and (2) adding the
feature you wanted to add, please?

To do that without too much hassle, I would: first, start again from a
new branch, make the "move to a function" commit; second, take the code
with the extra feature from the other branch and let git turn it into a
commit; third, clean up that commit.

Thanks in advance.

  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220703/8b9d7e9d/attachment.sig>

More information about the ffmpeg-devel mailing list