[FFmpeg-devel] [PATCH 1/2] avformat/argo_cvg: name unk{1, 2} fields correctly

[Zane van Iperen]

On 18/7/2022 11:45 pm, Andreas Rheinhardt wrote:

>>       av_log(s, AV_LOG_TRACE, "size       = %u\n", ctx->header.size);
>> -    av_log(s, AV_LOG_TRACE, "unk        = %u, %u\n", ctx->header.unk1, ctx->header.unk2);
>> +    av_log(s, AV_LOG_TRACE, "loop       = %u\n", ctx->header.loop);
>> +    av_log(s, AV_LOG_TRACE, "reverb     = %u\n", ctx->header.reverb);
> 
> %u is for unsigned, yet these variables are of type uint32_t. It is not
> guaranteed that these two types are the same (yet they typically are).
> That's why the PRI-macros exist.

Good catch, I'll rectify that.

> (Apart from that: Does this have to be three separate av_logs?)
> 
I can probably just remove them, now that I know what the fields are.

Although, I wouldn't mind exposing them as additional metadata...