[FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: update for new tone mapping API

[Lynne]

25 Mar 2022, 13:27 by ffmpeg at haasn.xyz:

> From: Niklas Haas <git at haasn.dev>
>
> Upstream gained a new tone-mapping API, which we never switched to. We
> don't need a version bump for this because it was included as part of
> the v4.192 release we currently already depend on.
>
> The "tonemapping" was changed from an enum to a string, owing to the new
> (extensible) upstream tone mapping infrastructure. The old names still
> map cleanly to the new API, so this shouldn't break any typical users.
>
> Some of the remaining options can be moderately approximated with the
> new API, but specifically "desaturation_base" and "max_boost" cannot.
> Remove these entirely, rather than deprecating them. They have been
> non-functional for a while as a result of the upstream deprecation.
>
> Signed-off-by: Niklas Haas <git at haasn.dev>
>

I'm sorry, but I can't accept that. The old API was well-exposed with all
its values available to the user via established methods.
Requiring a user to run once just to know all the available option is
reserved for the dumbest possible APIs like v4l2 and we shouldn't
be adding more of the same to encourage libraries to be lazy
with exposing options in the API.