[FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

Martijn van Beurden mvanb1 at gmail.com
Wed Mar 30 20:54:49 EEST 2022

First of all, thanks for reviewing

Op wo 30 mrt. 2022 om 12:42 schreef Andreas Rheinhardt
<andreas.rheinhardt at outlook.com>:
> Can this happen with real encoders or has this file been specifically
> crafted? What is the performance impact of this patch on ordinary files?

This file has been crafted. It seems unlikely to occur in the wild,
but it is not impossible.

Anyway, I found this 'problem' while doing some research for the IETF
CELLAR working group, which is in the process of creating an RFC on
FLAC. Perhaps I sent in this patch too hastily, on second thought it
might be better to fix this in FLAC encoder implementations, of which
there are few, instead of FLAC decoders, of which there are many. As
the IETF is in the process of amending the FLAC specification anyway,
such a provision could very well be included.

Sorry for sending this patch in too soon, once more thanks for reviewing this.

More information about the ffmpeg-devel mailing list