[FFmpeg-devel] [crop support for matroska demuxer 2/3] libavcodec: Public code to support container crop

Anton Khirnov anton at khirnov.net
Tue Oct 4 14:35:54 EEST 2022


Quoting Hendrik Leppkes (2022-10-01 09:16:20)
> Somehow I don't feel like adding the two crops together is really
> going to do what most users would expect to happen. It just feels
> weird.
> It also changes the decoder crop information, and an API user does not
> get the pure information from the decoder, but rather an "interpreted"
> form. As an API user, I do not get the ability here to extract the
> pure decoder crop info, unless I manually null out the container info
> beforehand, or subtract it again, both of which seems odd and
> undesirable to me. Shouldn't I be provided with clean information, and
> then I (the API user) can choose how to act?

I agree, such policy decisions belong in the caller, not our libraries.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list