[FFmpeg-devel] [PATCH 1/3] lavu/pixfmt: Add P012, Y212, XV30, and XV36 formats

[Philip Langdale]

On Mon, 5 Sep 2022 11:51:56 -0300
James Almer <jamrial at gmail.com> wrote:

> On 8/25/2022 11:17 PM, Philip Langdale wrote:
> >   static const char * const color_range_names[] = {
> > @@ -2778,7 +2871,7 @@ void ff_check_pixfmt_descriptors(void){
> >   
> >           if (!d->name && !d->nb_components && !d->log2_chroma_w &&
> > !d->log2_chroma_h && !d->flags) continue;
> > -//         av_log(NULL, AV_LOG_DEBUG, "Checking: %s\n", d->name);
> > +        av_log(NULL, AV_LOG_INFO, "Checking: %s\n", d->name);
> >           av_assert0(d->log2_chroma_w <= 3);
> >           av_assert0(d->log2_chroma_h <= 3);
> >           av_assert0(d->nb_components <= 4);  
> 
> Unintended change?

Actually intended. Because if there is a problem and the assert fails,
you can't tell what format was being tested. It seems you want it on
all the time, otherwise the test isn't helpful out-of-the-box.

--phil