[FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

Michael Niedermayer michael at niedermayer.cc
Fri Sep 16 20:26:55 EEST 2022


On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal at sandflow.com wrote:
> From: Pierre-Anthony Lemieux <pal at palemieux.com>
> 
> Addresses coverity 1512414
> 
> ---
>  libavformat/imfdec.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 5bbe7a53f8..58b1455c9f 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma
>  {
>      IMFContext *c = s->priv_data;
>      IMFVirtualTrackPlaybackCtx *track;

> +    AVRational minimum_timestamp = av_make_q(INT_MAX, 1);
> -    AVRational minimum_timestamp = av_make_q(INT32_MAX, 1);

iam not sure thats a good idea, it would change behavior on different platforms

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220916/8ad76e6b/attachment.sig>


More information about the ffmpeg-devel mailing list