[FFmpeg-devel] [PATCH 05/31] lavu/cpu: CPU flags for the RISC-V Vector extension

[Andreas Rheinhardt]

Lynne:
> Sep 25, 2022, 16:25 by remi at remlab.net:
> 
>> From: Rémi Denis-Courmont <remi at remlab.net>
>> -    if ((flags & AV_CPU_FLAG_RVD) && !(flags & AV_CPU_FLAG_RVF)) {
>> +    if ((flags & AV_CPU_FLAG_RV_ZVE64D) && !(flags & AV_CPU_FLAG_RV_ZVE64X)) {
>> +        av_log(NULL, AV_LOG_WARNING, "RV%s implied by specified flags\n",
>> +               "_ZVE64X");
>> +        flags |= AV_CPU_FLAG_RV_ZVE64X;
>> +    }
>> +
>> +    if ((flags & AV_CPU_FLAG_RV_ZVE64D) && !(flags & AV_CPU_FLAG_RV_ZVE32F)) {
>> +        av_log(NULL, AV_LOG_WARNING, "RV%s implied by specified flags\n",
>> +               "_ZVE32F");
>>
> 
> I remember someone complaining about NULL contexts in av_log (mkver?).
> I think it's okay, but I have no opinion on this.
> 

You are probably referring to Anton; I also dislike them, but not as
much as he. Anyway, the actual caller provides no logcontext, so it is
fine by me to use NULL. This does not mean that I would add these
av_logs myself.

- Andreas