[FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

Paul B Mahol onemda at gmail.com
Fri Dec 1 23:27:15 EET 2023


On Fri, Dec 1, 2023 at 10:13 PM Kyle Swanson <k at ylo.ph> wrote:

> Hi,
>
> On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol <onemda at gmail.com> wrote:
> > Keeping old code will not make patch any prettier.
>
> It's not really about pretty, it's about splitting up the patch so we
> can do things one at a time. I think the change to use f_ebur128.c
> loudness computation might have some advantages, but I can't test them
> in isolation. The changes to the loudnorm algorithm I have more
> questions about, but I can't test those in isolation either.
>

Define what isolation means for you?

You all are just allowing poor code state and quality stay.


>
> Thanks,
> Kyle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>


More information about the ffmpeg-devel mailing list