[FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

[Rémi Denis-Courmont]

Le 30 décembre 2023 15:00:53 GMT+01:00, flow gg <hlefthleft at gmail.com> a écrit :
>> At a quick glance, it won't work if the input length is not a multiple of
>the vector length.
>
>Why?

You're not handling tails as far as I see.

> I tried 1024, 32*3, 32*7 and all passed the test.

They're all multiples of the vector length.

>> Also do you really need to extend accumulators to 32 bits?
>
>It won't overflow after the test is changed, so it's not needed anymore.
>I have modified it in this reply.
>
>Rémi Denis-Courmont <remi at remlab.net> 于2023年12月30日周六 20:15写道：
>
>>
>>
>> Le 29 décembre 2023 12:57:20 GMT+01:00, flow gg <hlefthleft at gmail.com> a
>> écrit :
>> >C908
>> >ssd_int8_vs_int16_c: 207.7
>> >ssd_int8_vs_int16_rvv_i32: 28.0
>>
>> At a quick glance, it won't work if the input length is not a multiple of
>> the vector length.
>>
>> Also do you really need to extend accumulators to 32 bits?
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel at ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".