[FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter

[Thilo Borgmann]

Am 18.12.23 um 12:02 schrieb Thilo Borgmann via ffmpeg-devel:
> Am 17.12.23 um 23:51 schrieb Michael Niedermayer:
>> On Sat, Dec 16, 2023 at 09:13:21AM +0100, Thilo Borgmann via ffmpeg-devel wrote:
>> [...]
>>
>>> +// get number of bytes from cur to '\0'
>>> +static int buf_get_zero(FsyncContext *ctx)
>>
>> maybe doxygen syntax would make sense for comments descrining functions
>> its not public api but still maybe
> 
> Better still. Done.
> 
> 
>>> +{
>>> +    return av_strnlen(ctx->cur, ctx->end - ctx->cur);
>>> +}
>>> +
>> [...]
>>> +    if (s->last_frame) {
>>> +        ret = av_sscanf(s->cur, "%"PRId64" %"PRId64" %d/%d", &s->ptsi, &s->pts, &s->tb_num, &s->tb_den);
>>> +        if (ret != 4) {
>>> +            av_log(ctx, AV_LOG_ERROR, "Unexpected format found (%i / 4).\n", ret);
>>> +            ff_outlink_set_status(outlink, AVERROR_INVALIDDATA, AV_NOPTS_VALUE);
>>> +            return AVERROR_INVALIDDATA;
>>> +        }
>>> +
>>> +        av_log(ctx, AV_LOG_DEBUG, "frame %lli ", s->last_frame->pts);
>>
>> warning: format ‘%lli’ expects argument of type ‘long long int’, but argument 4 has type ‘int64_t {aka long int}’ [-Wformat=]
>>
>> "%"PRIi64 / "%"PRId64 / "%"PRIu64 / "%"PRIx64
> 
> "%"PRId64 it shall be here and for the other DEBUG logs.
> 
> All done locally, I'd appreciate if someone could test this on Windows, I'm curious about line endings in the map file...

Will push this soon if there are no further comments.

-Thilo