[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.
Zhao Zhili
quinkblack at foxmail.com
Sat Nov 25 06:08:40 EET 2023
> On Nov 25, 2023, at 05:32, David Bohman <debohman at gmail.com> wrote:
>
> On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili <quinkblack at foxmail.com> wrote:
>>
>>> On Nov 24, 2023, at 23:40, David Bohman <debohman at gmail.com> wrote:
>>>
>>> This is to fix a build failure on macOS < 10.13.
>>>
>> It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build failure.
>> I prefer use compat_keys, so it can be build on macOS < 10.13, get the key at runtime
>> and run on macOS >= 10.13.
>
> Correct, kVTCompressionPropertyKey_EncoderID appeared in 10.13,
> according to the Apple Developer documentation.
>
> Are you going to do your own fix?
Could you test the following patch? Thanks.
https://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317366.html
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
More information about the ffmpeg-devel
mailing list