[FFmpeg-devel] [PATCH 34/42] avcodec/vp9: Replace atomic_store() by atomic_init()
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Tue Sep 19 22:57:26 EEST 2023
This part of the code is not slice-threaded and they are
semantically an initialization, so use atomic_init()
instead of the potentially expensive atomic_store()
(which uses sequentially consistent memory ordering).
Also remove the initial initialization directly after
allocating this array.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
libavcodec/vp9.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
index 8eba56b720..62ae0f5882 100644
--- a/libavcodec/vp9.c
+++ b/libavcodec/vp9.c
@@ -54,7 +54,6 @@ DEFINE_OFFSET_ARRAY(VP9Context, vp9_context, pthread_init_cnt,
static int vp9_alloc_entries(AVCodecContext *avctx, int n) {
VP9Context *s = avctx->priv_data;
- int i;
if (avctx->active_thread_type & FF_THREAD_SLICE) {
if (s->entries)
@@ -63,9 +62,6 @@ static int vp9_alloc_entries(AVCodecContext *avctx, int n) {
s->entries = av_malloc_array(n, sizeof(atomic_int));
if (!s->entries)
return AVERROR(ENOMEM);
-
- for (i = 0; i < n; i++)
- atomic_init(&s->entries[i], 0);
}
return 0;
}
@@ -1656,7 +1652,7 @@ static int vp9_decode_frame(AVCodecContext *avctx, AVFrame *frame,
#if HAVE_THREADS
if (avctx->active_thread_type & FF_THREAD_SLICE) {
for (i = 0; i < s->sb_rows; i++)
- atomic_store(&s->entries[i], 0);
+ atomic_init(&s->entries[i], 0);
}
#endif
--
2.34.1
More information about the ffmpeg-devel
mailing list