[FFmpeg-devel] [PATCH] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH

[James Almer]

On 9/25/2023 7:45 PM, Andreas Rheinhardt wrote:
> It is of no value to the user, because every muxer can always
> be flushed with a NULL packet. As its documentation shows
> ("If not set, the muxer will not receive a NULL packet in
> the write_packet function") it is actually an internal flag
> that has been publically exposed because there were no internal
> flags for output formats for a long time. But now there is
> and so use it by replacing the public flag with a private one.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   doc/APIchanges                |  4 ++++
>   libavdevice/pulse_audio_enc.c |  5 ++++
>   libavformat/avformat.h        |  6 +++--
>   libavformat/fifo.c            |  5 ++++
>   libavformat/fifo_test.c       |  5 ++++
>   libavformat/hlsenc.c          |  5 ++++
>   libavformat/matroskaenc.c     | 15 ++++++++++++
>   libavformat/movenc.c          | 45 +++++++++++++++++++++++++++++++++++
>   libavformat/mpegtsenc.c       |  5 ++++
>   libavformat/mux.c             |  6 +++++
>   libavformat/mux.h             |  6 +++--
>   libavformat/oggenc.c          | 25 +++++++++++++++++++
>   libavformat/tee.c             |  5 ++++
>   libavformat/version_major.h   |  1 +
>   14 files changed, 134 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index f333ff5b24..b9d50b1db5 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2023-02-09
>   
>   API changes, most recent first:
>   
> +2023-09-26 - xxxxxxxxxx - lavf 60.xx.100 - avformat.h
> +  Deprecate AVFMT_ALLOW_FLUSH without replacement. Users can always
> +  flush any muxer by sending a NULL muxer.

NULL packet.