[FFmpeg-devel] [PATCH 29/61] avcodec/mobiclip: Avoid unnecessary VLC structure

[Andreas Rheinhardt]

Michael Niedermayer:
> On Wed, Sep 27, 2023 at 12:17:00AM +0200, Andreas Rheinhardt wrote:
>> Everything besides VLC.table is basically write-only
>> and only VLC.table needs to be retained.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
>> ---
>>  libavcodec/mobiclip.c | 41 ++++++++++++++++++-----------------------
>>  1 file changed, 18 insertions(+), 23 deletions(-)
> 
> This produces (vissible) difference in some files
> 
> for example https://samples.ffmpeg.org/game-formats/moflex/B7.moflex
> (this doesnt seem to decode correctly before either but it looks
> worse here after this change)
> 

Correct, I am initializing rl_vlc[1} with the wrong symbols table.
Thanks for spotting this.

- Andreas