[FFmpeg-devel] [PATCH] avformat/mxfdec: only check index_edit_rate when calculating the index tables

[Tomas Härdin]

mån 2024-04-15 klockan 21:34 +0200 skrev Marton Balint:
> Commit ed49391961999f028e0bc55767d0eef6eeb15e49 started rejecting
> negative
> index segment edit rates to avoid negative av_rescale parameters.
> There are two
> problems with this:
> 
> 1) there is already a validation for zero (uninitialized) rates later
> on
> 2) it rejects files with 0/0 index edit rates which do exist and we
> should
> continue to support those

There are no such files in FATE last time I checked. At the very least
we need to know which vendor is producing such broken files.

Without tests covering the workflows we want to support, we have no
confidence in refactoriing. This leads to cargo culting. And to be
sure, every workflow we support means a non-trivial amount of work,
especially when it comes to MXF.

/Tomas