[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

[Andreas Rheinhardt]

Michael Niedermayer:
> Fixes: CID1397741 Unchecked return value
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavfilter/avfiltergraph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
> index 0c569eb218e..4eeaa33d5e9 100644
> --- a/libavfilter/avfiltergraph.c
> +++ b/libavfilter/avfiltergraph.c
> @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph)
>          if (r == AVERROR(EAGAIN) &&
>              !oldest->frame_wanted_out && !oldesti->frame_blocked_in &&
>              !oldesti->status_in)
> -            ff_request_frame(oldest);
> +            ff_request_frame(oldest); // return value is intentionally ignored
>          else if (r < 0)
>              return r;
>      }

Isn't the typical way to signal this to cast the return value to void?

- Andreas