[FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: switch to new swscale API

[Michael Niedermayer]

On Sat, Dec 07, 2024 at 07:10:49PM +0100, Niklas Haas wrote:
> On Fri, 06 Dec 2024 20:57:54 +0100 Michael Niedermayer <michael at niedermayer.cc> wrote:
> > Hi
> >
> > On Fri, Dec 06, 2024 at 02:40:06PM +0100, Niklas Haas wrote:
> > > On Fri, 06 Dec 2024 14:31:43 +0100 Michael Niedermayer <michael at niedermayer.cc> wrote:
> > > > Hi
> > > >
> > > > On Mon, Nov 25, 2024 at 10:11:49AM +0000, Niklas Haas wrote:
> > > > > ffmpeg | branch: master | Niklas Haas <git at haasn.dev> | Fri Jun 28 21:42:23 2024 +0200| [04ce01df0bb2d66e143bcfcea439afc2a1b8d96e] | committer: Niklas Haas
> > > > >
> > > > > avfilter/vf_scale: switch to new swscale API
> > > > >
> > > > > Most logic from this filter has been co-opted into swscale itself,
> > > > > allowing the resulting filter to be substantially simpler as it no
> > > > > longer has to worry about context initialization, interlacing, etc.
> > > > >
> > > > > Sponsored-by: Sovereign Tech Fund
> > > > > Signed-off-by: Niklas Haas <git at haasn.dev>
> > > > >
> > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=04ce01df0bb2d66e143bcfcea439afc2a1b8d96e
> > > > > ---
> > > > >
> > > > >  libavfilter/vf_scale.c | 351 +++++++++++--------------------------------------
> > > > >  1 file changed, 77 insertions(+), 274 deletions(-)
> > > >
> > > > It seems this broke:
> > > >
> > > > ./ffmpeg -i mm-short.mpg -vcodec prores -vframes 3 -bitexact -an prores.mkv
> > > > ./ffplay prores.mkv
> > > >
> > > > [swscaler @ 0x7f76380068c0] Unsupported input (Operation not supported): fmt:yuv422p10le csp:gbr prim:reserved trc:reserved -> fmt:yuv420p csp:bt709 prim:reserved trc:reserved
> > >
> > > What is the meaning of AVCOL_*_RESERVED and why should we accept it here?
> > >
> > > If you look at e.g. H.273, it clearly reserves these values for future use,
> > > and so IMHO treatind them as invalid inputs is not entirely incorrect.
> > >
> > > Could we fix the prores decoder to instead output UNSPECIFIED?
> >
> > the decoder should probably output the value stored in the file.
> >
> > I have to say its a little odd a file generated by ffmpeg contains a
> > reserved value but how do i know without a prores spec ...
> >
> > Now even if theres an argument for the prores decoder not to output that
> > value here. Another decoder and other file could still have exactly that
> > reserved value. And in that case that decoder should output that
> 
> Should we:
> 
> 1) Treat RESERVED as UNSPECIFIED

yes, and maybe warn if a transform needs this value

There also could be some code between the decoder and the filter that replaces
reserved. It kind of doesnt really make a difference where we deal with this

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241207/babf897c/attachment.sig>