[FFmpeg-devel] [PATCH] fate: Add a dependency on ffprobe for fate-flcl1905

[Ramiro Polla]

On Thu, Dec 12, 2024 at 1:28 PM Martin Storsjö <martin at martin.st> wrote:
>
> This fixes occasional failed tests, if doing "make fate" without a
> regular "make" or "make all" inbetween.
> ---
>  tests/fate/audio.mak | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
> index 4d6c479b6b..6e091760ea 100644
> --- a/tests/fate/audio.mak
> +++ b/tests/fate/audio.mak
> @@ -82,10 +82,12 @@ fate-smacker-audio: CMD = framecrc -i $(TARGET_SAMPLES)/smacker/wetlogo.smk -vn
>  FATE_SAMPLES_AUDIO-$(call DEMDEC, WSVQA, WS_SND1, ARESAMPLE_FILTER) += fate-ws_snd
>  fate-ws_snd: CMD = md5 -i $(TARGET_SAMPLES)/vqa/ws_snd.vqa -f s16le -af aresample
>
> -FATE_SAMPLES_AUDIO-$(call DEMDEC, WAV, WMAV2, FILE_PROTOCOL) += fate-flcl1905
> +FATE_SAMPLES_AUDIO_FFPROBE-$(call DEMDEC, WAV, WMAV2, FILE_PROTOCOL) += fate-flcl1905
>  fate-flcl1905: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_frames -show_packets -print_format compact $(TARGET_SAMPLES)/wav/FLCL_Ending_My-short.wav
>
>  FATE_SAMPLES_AUDIO += $(FATE_SAMPLES_AUDIO-yes)
> +FATE_SAMPLES_AUDIO_FFPROBE += $(FATE_SAMPLES_AUDIO_FFPROBE-yes)
>
>  FATE_SAMPLES_FFMPEG += $(FATE_SAMPLES_AUDIO)
> -fate-audio: $(FATE_SAMPLES_AUDIO)
> +FATE_SAMPLES_FFPROBE += $(FATE_SAMPLES_AUDIO_FFPROBE)
> +fate-audio: $(FATE_SAMPLES_AUDIO) $(FATE_SAMPLES_AUDIO_FFPROBE)
> --

I've had something similar locally for a while as well. This looks good to me.