[FFmpeg-devel] [PATCH v2 02/17] swscale/utils: add HDR metadata to SwsFormat

[Niklas Haas]

On Thu, 19 Dec 2024 05:07:16 +0100 Michael Niedermayer <michael at niedermayer.cc> wrote:
> Hi
>
>
> On Mon, Dec 16, 2024 at 12:17:23PM +0100, Niklas Haas wrote:
> [...]
> > diff --git a/libswscale/utils.h b/libswscale/utils.h
> > index 4d204ef6cc..52b1e67644 100644
> > --- a/libswscale/utils.h
> > +++ b/libswscale/utils.h
> > @@ -21,26 +21,55 @@
> >  #ifndef SWSCALE_UTILS_H
> >  #define SWSCALE_UTILS_H
> >
> > +#include "libavutil/csp.h"
> >  #include "libavutil/pixdesc.h"
> >
> >  #include "swscale.h"
> >
> > +/* Like av_cmp_q but considers x/0 == y/0 */
> > +static inline int ff_q_equal(const AVRational a, const AVRational b)
> > +{
> > +    return (!a.den && !b.den) || !av_cmp_q(a, b);
> > +}
>
> if thats true for all cases then ok
>
> feels a little odd to me that -inf == NaN == +inf

Good point. I'll change it to only exclude the NaN case then.

>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I know you won't believe me, but the highest form of Human Excellence is
> to question oneself and others. -- Socrates
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".