[FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

[Connor Worley]

On Mon, Feb 5, 2024 at 12:06 PM Andreas Rheinhardt <
andreas.rheinhardt at outlook.com> wrote:

> Connor Worley:
> >>
> >> How much would one gain if the hash function knew that key_size and
> >> val_size are four?
> >>
> >
> > That yields a nice 10-20% speedup on my machine. Are you thinking of
> macros
> > to parametrize key/val size, or possibly optimized versions for common
> > sizes?
>
> I am thinking about it not being public at all; as long as we have only
> one user...
>

 That's fair. I will need some variants for future DXV work, but they can
also be private if this doesn't seem generally useful.

PS: Is the speedup only for the hashing part or for overall decoding? Is
> the comparison the current version of your patch or something that
> already has my comments incorporated?
>

Overall encoding -- current version of my patch with ctx->key/val_size vs
hardcoded sizes.

-- 
Connor Worley