[FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs

[Lynne]

Feb 7, 2024, 03:11 by kasper93 at gmail.com:

> Drop per frame decode messages to AV_LOG_TRACE level.
>
> Signed-off-by: Kacper Michajłow <kasper93 at gmail.com>
> ---
>  libavcodec/vulkan_av1.c  | 2 +-
>  libavcodec/vulkan_h264.c | 2 +-
>  libavcodec/vulkan_hevc.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/vulkan_av1.c b/libavcodec/vulkan_av1.c
> index 9730e4b08d..c7d5a54012 100644
> --- a/libavcodec/vulkan_av1.c
> +++ b/libavcodec/vulkan_av1.c
> @@ -530,7 +530,7 @@ static int vk_av1_end_frame(AVCodecContext *avctx)
>  rav[i] = ap->ref_src[i]->f;
>  }
>  
> -    av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n",
> +    av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i tiles\n",
>  vp->slices_size, ap->tile_list.nb_tiles);
>  
>  return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp);
> diff --git a/libavcodec/vulkan_h264.c b/libavcodec/vulkan_h264.c
> index 39c123ddca..c918dbaa13 100644
> --- a/libavcodec/vulkan_h264.c
> +++ b/libavcodec/vulkan_h264.c
> @@ -529,7 +529,7 @@ static int vk_h264_end_frame(AVCodecContext *avctx)
>  rav[i] = hp->ref_src[i]->f;
>  }
>  
> -    av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n",
> +    av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n",
>  vp->slices_size, hp->h264_pic_info.sliceCount);
>  
>  return ff_vk_decode_frame(avctx, pic->f, vp, rav, rvp);
> diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c
> index 033172cbd6..0f6f2e775b 100644
> --- a/libavcodec/vulkan_hevc.c
> +++ b/libavcodec/vulkan_hevc.c
> @@ -903,7 +903,7 @@ static int vk_hevc_end_frame(AVCodecContext *avctx)
>  rvp[i] = &rfhp->vp;
>  }
>  
> -    av_log(avctx, AV_LOG_VERBOSE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n",
> +    av_log(avctx, AV_LOG_TRACE, "Decoding frame, %"SIZE_SPECIFIER" bytes, %i slices\n",
>  vp->slices_size, hp->h265_pic_info.sliceSegmentCount);
>  
>  return ff_vk_decode_frame(avctx, pic->frame, vp, rav, rvp);
>

I don't agree with this, without this print,
you have no idea if hardware decoding is even being used.
MP4 parsing is far too noisy than a single print per frame.